added test helper

articles/test_pr_upload.py

@@ -50,6 +50,27 @@ class CropPRIntegration(TransactionTestCase):
         self.assertEqual(article.reach, 187566)
 
 
+def add_medium_helper(medium_name_list):
+    """ helps to perform tests for medium insertion """
+    file = Files.objects.get(upload_file='testfile.pdf')
+    input_data = {
+        'medium_type': 'Zeitung',
+        'name': 'Testartikel',
+        'source_file': file,
+        'reach': 1000,
+        'date_of_publication': '1988-12-30',
+        'text': 'Dies ist ein beispielhafter Beispieltext',
+        'pages': 2,
+        'wrongly_parsed': True,
+        'tags': ['tag1', 'tag2']
+    }
+
+    for medium_name in medium_name_list:
+        input_data['name'] = medium_name + " - Artikel"
+        input_data['medium_name'] = medium_name
+        write_article_to_db(**input_data)
+
+
 class DbHandler(TransactionTestCase):
     """ Test the db integration"""
     reset_sequences = True
@@ -143,86 +164,38 @@ class DbHandler(TransactionTestCase):
     def test_write_articles_medium_with_dash(self):
         """ test if medium and submedium will be merged """
         logger.info("started test_write_articles_reach_string")
-        file = Files.objects.get(upload_file='testfile.pdf')
-        input_data = {
-            'medium_name': 'Märkische Allgemeine',
-            'medium_type': 'Zeitung',
-            'title': 'Testartikel',
-            'source_file': file,
-            'reach': 1000,
-            'date_of_publication': '1988-12-30',
-            'text': 'Dies ist ein beispielhafter Beispieltext1',
-            'pages': 2,
-            'wrongly_parsed': True,
-            'tags': ['tag1', 'tag2']
-        }
-        write_article_to_db(**input_data)
-        input_data['medium_name'] = 'Märkische Allgemeine - Potsdamer'
-        write_article_to_db(**input_data)
+        add_medium_helper(['Märkische Allgemeine', 'Märkische Allgemeine - Potsdamer'])
         self.assertEqual(Medium.objects.filter(name='märkische allgemeine').count(), 1)
-        input_data['medium_name'] = 'Lausitzer Rundschau'
-        write_article_to_db(**input_data)
-        self.assertEqual(Medium.objects.filter(name='lausitzer rundschau').count(), 1)
-        input_data['medium_name'] = 'Lausitzer Rundschau Cottbus'
-        write_article_to_db(**input_data)
+
+        add_medium_helper(['Lausitzer Rundschau', 'Lausitzer Rundschau Cottbus'])
         self.assertEqual(Medium.objects.filter(name='lausitzer rundschau').count(), 1)
         self.assertEqual(Medium.objects.all().count(), 2)
-        input_data['medium_name'] = 'Welt Am Sonntag'
-        write_article_to_db(**input_data)
-        input_data['medium_name'] = 'welt.de'
-        write_article_to_db(**input_data)
-        input_data['medium_name'] = 'welt online'
-        write_article_to_db(**input_data)
-        input_data['medium_name'] = 'dw'
-        write_article_to_db(**input_data)
-        input_data['medium_name'] = 'die welt'
-        write_article_to_db(**input_data)
+
+        add_medium_helper(['Welt Am Sonntag', 'welt.de', 'welt online', 'dw', 'die welt'])
         self.assertEqual(Medium.objects.all().count(), 5)
-        input_data['medium_name'] = 'nd'
-        write_article_to_db(**input_data)
-        input_data['medium_name'] = 'neues deutschland'
-        write_article_to_db(**input_data)
-        input_data['medium_name'] = 'nd (neues deutschland)'
-        write_article_to_db(**input_data)
+
+        add_medium_helper(['nd', 'neues deutschland', 'nd (neues deutschland)'])
         self.assertEqual(Medium.objects.all().count(), 6)
-        input_data['medium_name'] = 'wochenspiegel'
-        write_article_to_db(**input_data)
-        input_data['medium_name'] = 'wochenspiegel potsdam'
-        write_article_to_db(**input_data)
+
+        add_medium_helper(['wochenspiegel', 'wochenspiegel potsdam'])
         self.assertEqual(Medium.objects.all().count(), 7)
-        input_data['medium_name'] = 'bild'
-        write_article_to_db(**input_data)
-        input_data['medium_name'] = 'bild.de'
-        write_article_to_db(**input_data)
-        input_data['medium_name'] = 'bildplus'
-        write_article_to_db(**input_data)
-        input_data['medium_name'] = 'bild der frau'
-        write_article_to_db(**input_data)
+
+        add_medium_helper(['bild', 'bild.de', 'bildplus', 'bild der frau'])
         self.assertEqual(Medium.objects.all().count(), 9)
-        input_data['medium_name'] = 'Der Spiegel'
-        write_article_to_db(**input_data)
-        input_data['medium_name'] = 'Spiegel+'
-        write_article_to_db(**input_data)
+
+        add_medium_helper(['Der Spiegel', 'Spiegel+'])
         self.assertEqual(Medium.objects.all().count(), 10)
-        input_data['medium_name'] = 'nordkurier'
-        write_article_to_db(**input_data)
-        input_data['medium_name'] = 'nordkurier potsdam'
-        write_article_to_db(**input_data)
+
+        add_medium_helper(['nordkurier', 'nordkurier potsdam'])
         self.assertEqual(Medium.objects.all().count(), 11)
-        input_data['medium_name'] = 'schweriner volkszeitung'
-        write_article_to_db(**input_data)
-        input_data['medium_name'] = 'schweriner volkszeitung - Viertel'
-        write_article_to_db(**input_data)
+
+        add_medium_helper(['schweriner volkszeitung', 'schweriner volkszeitung - Viertel'])
         self.assertEqual(Medium.objects.all().count(), 12)
-        input_data['medium_name'] = 'frankfurter rundschau'
-        write_article_to_db(**input_data)
-        input_data['medium_name'] = 'frankfurter rundschau - Test'
-        write_article_to_db(**input_data)
+
+        add_medium_helper(['frankfurter rundschau', 'frankfurter rundschau - Test'])
         self.assertEqual(Medium.objects.all().count(), 13)
-        input_data['medium_name'] = 'nordwest-zeitung'
-        write_article_to_db(**input_data)
-        input_data['medium_name'] = 'nordwest-zeitung asd'
-        write_article_to_db(**input_data)
+
+        add_medium_helper(['nordwest-zeitung', 'nordwest-zeitung asd'])
         self.assertEqual(Medium.objects.all().count(), 14)